Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docker instructions clearer for Postgres #10501

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Make docker instructions clearer for Postgres #10501

merged 1 commit into from
Jul 10, 2024

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Jul 10, 2024

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 10, 2024
JaroslavTulach
JaroslavTulach approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. With these instructions I am able to reproduce the postgresQL problem locally.

@JaroslavTulach JaroslavTulach mentioned this pull request Jul 10, 2024
Merged
4 tasks
@AdRiley AdRiley merged commit ce6995c into develop Jul 10, 2024
37 checks passed
@AdRiley AdRiley deleted the wip/adr/update-database-readme branch July 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@radeusgd radeusgd radeusgd approved these changes

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdRiley @radeusgd @jdunkerley @JaroslavTulach